Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17: Make the quic server connection table use an async lock, reducing thrashing (backport of #293) #299

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Mar 18, 2024

Problem

Usage of sync locks on the quic server can cause thrashing when under lock contention

Summary of Changes

Use async lock

Fixes #


This is an automatic backport of pull request #293 done by [Mergify](https://mergify.com).

Copy link
Author

mergify bot commented Mar 18, 2024

Cherry-pick of 36e9765 has failed:

On branch mergify/bp/v1.17/pr-293
Your branch is up to date with 'origin/v1.17'.

You are currently cherry-picking commit 36e97654e3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   streamer/src/nonblocking/quic.rs

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

…ashing (#293)

Make the quic server connection table use an async lock, reducing lock contention

(cherry picked from commit 36e9765)
Copy link

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. @sakridge for stable bp approval

Copy link

@sakridge sakridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lijunwangs lijunwangs merged commit 29c004c into v1.17 Mar 18, 2024
31 checks passed
@lijunwangs lijunwangs deleted the mergify/bp/v1.17/pr-293 branch March 18, 2024 21:32
@HaoranYi HaoranYi mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants