Revert deprecate executable feature #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoranYi
force-pushed
the
feature/revert_executable
branch
from
66ac7ef
to
3e95fa4
Compare
HaoranYi
changed the title
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
Lichtso
approved these changes
Mar 20, 2024
pgarg66
approved these changes
Mar 20, 2024
mergify bot
pushed a commit
that referenced
this pull request
Mar 20, 2024
* revert deprecate executable feature * add native loader account transfer test --------- Co-authored-by: HaoranYi <haoran.yi@solana.com> (cherry picked from commit 0f8f8cd) # Conflicts: # programs/bpf_loader/src/lib.rs # runtime/src/accounts/mod.rs # runtime/src/bank.rs # runtime/src/bank/tests.rs # sdk/src/account.rs
HaoranYi
added a commit
that referenced
this pull request
Mar 21, 2024
* Revert deprecate executable feature (#309) * revert deprecate executable feature * add native loader account transfer test --------- Co-authored-by: HaoranYi <haoran.yi@solana.com> (cherry picked from commit 0f8f8cd) # Conflicts: # programs/bpf_loader/src/lib.rs # runtime/src/accounts/mod.rs # runtime/src/bank.rs # runtime/src/bank/tests.rs # sdk/src/account.rs * fix merge conflict * fix a test --------- Co-authored-by: HaoranYi <haoran.yi@gmail.com> Co-authored-by: HaoranYi <haoran.yi@solana.com>
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…anza-xyz#337) * Revert deprecate executable feature (anza-xyz#309) * revert deprecate executable feature * add native loader account transfer test --------- Co-authored-by: HaoranYi <haoran.yi@solana.com> (cherry picked from commit 0f8f8cd) # Conflicts: # programs/bpf_loader/src/lib.rs # runtime/src/accounts/mod.rs # runtime/src/bank.rs # runtime/src/bank/tests.rs # sdk/src/account.rs * fix merge conflict * fix a test --------- Co-authored-by: HaoranYi <haoran.yi@gmail.com> Co-authored-by: HaoranYi <haoran.yi@solana.com>
codebender828
pushed a commit
to codebender828/agave
that referenced
this pull request
Oct 3, 2024
* revert deprecate executable feature * add native loader account transfer test --------- Co-authored-by: HaoranYi <haoran.yi@solana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We reevaluated the feature to deprecate executable. We felt that this feature is
too complex and too risky for v1.18.
Therefore, we would like to revert this feature.
Summary of Changes
native_loaderowned accountFixes #