Rekey - alt_bn128 and poseidon_syscall #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x0ece
approved these changes
Mar 19, 2024
0x0ece
suggested changes
Mar 20, 2024
Lichtso
force-pushed
the
feature/rekey_alt_bn128_and_poseidon
branch
from
de09fd7
to
81f5ecb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #319 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 837 837
Lines 226874 226875 +1
=======================================
+ Hits 185868 185875 +7
+ Misses 41006 41000 -6 |
0x0ece
approved these changes
Mar 21, 2024
samkim-crypto
approved these changes
Mar 22, 2024
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
mergify bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
Adds simplify_alt_bn128_syscall_error_codes. (cherry picked from commit 8f830c4)
Lichtso
added a commit
that referenced
this pull request
Apr 23, 2024
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…) (anza-xyz#899) Rekey - alt_bn128 and poseidon_syscall (anza-xyz#319) Adds simplify_alt_bn128_syscall_error_codes. (cherry picked from commit 8f830c4) Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#294 requires new feature gate keys.
Summary of Changes
enable_alt_bn128_compression_syscallandenable_poseidon_syscall.simplify_alt_bn128_syscall_error_codes.