Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validator: Move --rocksdb-fifo-shred-storage-size to deprecated list #3669

Merged
merged 1 commit into from
Nov 16, 2024
Merged

validator: Move --rocksdb-fifo-shred-storage-size to deprecated list #3669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions validator/src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,20 +674,6 @@ pub fn app<'a>(version: &'a str, default_args: &'a DefaultArgs) -> App<'a, 'a> {
'level': stores shreds using RocksDB's default (level) compaction.",
),
)
.arg(
Arg::with_name("rocksdb_fifo_shred_storage_size")
.long("rocksdb-fifo-shred-storage-size")
.value_name("SHRED_STORAGE_SIZE_BYTES")
.takes_value(true)
.validator(is_parsable::<u64>)
.help(
"The shred storage size in bytes. The suggested value is at least 50% of your \
ledger storage size. If this argument is unspecified, we will assign a \
proper value based on --limit-ledger-size. If --limit-ledger-size is not \
presented, it means there is no limitation on the ledger size and thus \
rocksdb_fifo_shred_storage_size will also be unbounded.",
),
)
.arg(
Arg::with_name("rocksdb_ledger_compression")
.hidden(hidden_unless_forced())
Expand Down Expand Up @@ -2151,6 +2137,19 @@ fn deprecated_arguments() -> Vec<DeprecatedArg> {
.value_name("ROCKSDB_COMPACTION_INTERVAL_SLOTS")
.takes_value(true)
.help("Number of slots between compacting ledger"));
// Deprecated in v2.2
add_arg!(Arg::with_name("rocksdb_fifo_shred_storage_size")
.long("rocksdb-fifo-shred-storage-size")
.value_name("SHRED_STORAGE_SIZE_BYTES")
.takes_value(true)
.validator(is_parsable::<u64>)
.help(
"The shred storage size in bytes. The suggested value is at least 50% of your ledger \
storage size. If this argument is unspecified, we will assign a proper value based \
on --limit-ledger-size. If --limit-ledger-size is not presented, it means there is \
no limitation on the ledger size and thus rocksdb_fifo_shred_storage_size will also \
be unbounded.",
));
add_arg!(Arg::with_name("rocksdb_max_compaction_jitter")
.long("rocksdb-max-compaction-jitter-slots")
.value_name("ROCKSDB_MAX_COMPACTION_JITTER_SLOTS")
Expand Down
Loading