Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17: Discard packets statically known to fail (backport of #370) #374

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Mar 21, 2024

Problem

  • Can statically determine some transactions will fail execution

Summary of Changes

  • Discard them during receiving

Fixes #


This is an automatic backport of pull request #370 done by [Mergify](https://mergify.com).

* Discard packets statically known to fail

* add test

(cherry picked from commit 5f16932)

# Conflicts:
#	core/src/banking_stage/transaction_scheduler/scheduler_controller.rs
@mergify mergify bot added the conflicts label Mar 21, 2024
Copy link
Author

mergify bot commented Mar 21, 2024

Cherry-pick of 5f16932 has failed:

On branch mergify/bp/v1.17/pr-370
Your branch is up to date with 'origin/v1.17'.

You are currently cherry-picking commit 5f1693224e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   core/src/banking_stage/immutable_deserialized_packet.rs
	modified:   core/src/banking_stage/packet_deserializer.rs
	modified:   core/src/banking_stage/packet_receiver.rs

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   core/src/banking_stage/transaction_scheduler/scheduler_controller.rs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apfitzge apfitzge merged commit 749c529 into v1.17 Mar 21, 2024
33 checks passed
@apfitzge apfitzge deleted the mergify/bp/v1.17/pr-370 branch March 21, 2024 22:37
@HaoranYi HaoranYi mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants