v1.17: Remove unnecessary unwrap from simulate_transaction_unchecked() (backport of #35375)
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgarg66
force-pushed
the
v1.17-backport-356c6a38cfc8aedfe70d414a8d2a03210834aba0
branch
from
88de346
to
0c77757
Compare
…()` (backport of solana-labs#35375) Remove unnecessary unwrap from `simulate_transaction_unchecked()` (solana-labs#35375) Remove unnecessary unwrap from simulate_transaction_unchecked() (cherry picked from commit cb260f1) Co-authored-by: Pankaj Garg <pankaj@solana.com>
pgarg66
force-pushed
the
v1.17-backport-356c6a38cfc8aedfe70d414a8d2a03210834aba0
branch
from
0c77757
to
b4ab25c
Compare
t-nelson
approved these changes
Mar 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.17 #65 +/- ##
=======================================
Coverage 81.6% 81.6%
=======================================
Files 806 806
Lines 219092 219096 +4
=======================================
+ Hits 178852 178895 +43
+ Misses 40240 40201 -39 |
|
@willhickey can this PR be audited before we merge it? |
pgarg66
deleted the
v1.17-backport-356c6a38cfc8aedfe70d414a8d2a03210834aba0
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary unwrap from
simulate_transaction_unchecked()(solana-labs#35375)Remove unnecessary unwrap from simulate_transaction_unchecked()
(cherry picked from commit cb260f1)
Recreating solana-labs#35396 in anza repo.
Fixes #