v1.18: Simd 129: alt_bn128 syscalls - simplified error code (backport of #294) #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
|
Waiting until #899 is merged. |
* alt_bn128: simplify errors in sycalls (alt_bn128, compress, poseidon) * add TODO for feature gate. remove validate from compress * add feature gate * fix one more error case * all changes under feature gate * revert removing from() * return unexpected errors in lib * add comment to remove error types, once the feature gate is activated * remove unnecessary/impossible error * fix mispelled comments (cherry picked from commit 64260fc)
samkim-crypto
force-pushed
the
mergify/bp/v1.18/pr-294
branch
from
e953f98
to
16d8634
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.18 #872 +/- ##
=========================================
- Coverage 81.6% 81.5% -0.1%
=========================================
Files 827 827
Lines 225122 225125 +3
=========================================
- Hits 183712 183683 -29
- Misses 41410 41442 +32 |
Lichtso
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The alt_bn128 family of syscalls have a wide range of return errors (some of which also invalid/that can never happen). We'd like to simplify to limit the risk of consensus issue among different clients (e.g. Agave vs Firedancer).
Summary of Changes
Ok(1)instead ofOk(e.into()), i.e. one single error code for the syscallsSyscallAltBn128Feature Gate Issue: #320
SIMD-0129: solana-foundation/solana-improvement-documents#129
This is an automatic backport of pull request #294 done by Mergify.