remove token-2022 dep from rpc-client-api #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
changed the title
filter_allows
kevinheavey
force-pushed
the
rpc-client-api-remove-token22-dep
branch
from
9ab4b14 to
6152a3c
Compare
buffalojoec
previously approved these changes
Apr 30, 2024
buffalojoec
added
the
automerge
mergify
bot
removed
the
automerge
|
automerge label removed due to a CI failure |
|
That test failure looks legitimate, which is why I haven't approved this yet. Can you please take a look @kevinheavey ? |
|
Incidentally @kevinheavey , if you get tired of waiting on us to add the CI label every time, you could apply for triage contributor access to agave: https://github.com/anza-xyz/contributor-access-policy |
CriesofCarrots
approved these changes
May 1, 2024
CriesofCarrots
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
solana-rpc-client-apidepends onspl-token-2022for theallows()method ofRpcFilterType.spl-token-2022is a very heavy dependency and anyway theallows()method is for the RPC server, not the client.Summary of Changes
RpcFilterType::allowstosolana-rpcas a free functionfilter_allowsRpcFilterType::allowsspl-token-2022dependency fromsolana-rpc-client-apiby using the spl-inline crate instead