v1.18: quic: delay calling set_max_concurrent_uni_streams/set_receive_window (backport of #904) #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
t-nelson
approved these changes
Apr 23, 2024
|
@mergify rebase |
❌ Unable to rebase: user
|
lijunwangs
force-pushed
the
mergify/bp/v1.18/pr-904
branch
from
6238461
to
4131c9b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.18 #968 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.1%
=========================================
Files 827 827
Lines 225122 225122
=========================================
- Hits 183687 183679 -8
- Misses 41435 41443 +8 |
anwayde
pushed a commit
to firedancer-io/agave
that referenced
this pull request
Jul 23, 2024
…_window (backport of anza-xyz#904) (anza-xyz#968) quic: delay calling set_max_concurrent_uni_streams/set_receive_window (anza-xyz#904) * quic: don't call connection.set_max_concurrent_uni_streams if we're going to drop a connection Avoids taking a mutex and waking a task. * quic: don't increase the receive window before we've actually accepted a connection (cherry picked from commit 2770424) Co-authored-by: Alessandro Decina <alessandro.d@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay calling connection.set_max_concurrent_uni_streams() and connection.set_receive_window() to when we know we've accepted the connection. Avoids a short window where the peer could start transmitting even if we're going to drop the connection, and avoids taking the connection mutex and waking a task.
This is an automatic backport of pull request #904 done by Mergify.