Add returnSignature Configuration Field #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add returnSignature Configuration Field
Problem
The build was failing due to a type error in
buildWhirlpoolsSwap.ts
where the code was trying to access areturnSignature
configuration field that wasn't defined in the config schema. The specific error was:Solution
Added the
returnSignature
field to the configuration schema inconfig.json
. The field is configured withallowAll
type, which is one of the valid options defined inreturnSignature.ts
.Changes
Testing
yarn build
buildWhirlpoolsSwap
endpoint can now properly handle signature returns based on configurationAdditional Notes
The
returnSignature
configuration supports two types:allowAll
- Allows all signature returns without additional checksreCaptcha
- Requires reCAPTCHA verification (not used in this PR)For this fix, we used the
allowAll
type as it's the simplest configuration that resolves the build error while maintaining functionality.