Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glitchy image album cover image behavior in kitty Mac OS #399

Closed
fuzetsu opened this issue Mar 23, 2024 · 12 comments · Fixed by #400
Closed

Glitchy image album cover image behavior in kitty Mac OS #399

fuzetsu opened this issue Mar 23, 2024 · 12 comments · Fixed by #400
Labels
bug Something isn't working

Comments

@fuzetsu
Copy link

fuzetsu commented Mar 23, 2024

Describe the bug
Album cover image rendering is glitchy in kitty (the terminal app) running on Mac OS:

  • image is stretched
  • image dupes and stacks at bottom left of the screen when you navigate to help screen ?

Of note is that this works fine in iterm2 (and maybe most terminal emulators?)
I suppose this might be a bug in kitty? difference in how images are cleaned up between screens?

To Reproduce
Open any song with album art and notice image is stretched. Press ? to open help screen and

Expected behaviour
Image should appear and disappear as expected and should be scaled appropriately.

Screenshots
image

Environment

  • OS: MacOS 14.3.1
  • Application version: 0.17.1
  • Kitty version: 0.33.1
@fuzetsu fuzetsu added the bug Something isn't working label Mar 23, 2024
@aome510
Copy link
Owner

aome510 commented Mar 23, 2024

@fuzetsu thanks for reporting. Can confirm this issue also happens to me with image on iterm2. I didn't notice this issue as I don't really use ? for help page nowadays 😅 .

aome510 added a commit that referenced this issue Mar 23, 2024
Resolves #399.

Fix rendering issue with `image` feature when a popup is rendered on top of the cover image. This PR updates the UI logic to ensure that the whole playback window is always visible from the UI.
@aome510
Copy link
Owner

aome510 commented Mar 23, 2024

Should be fixed with #400. Can you try the latest master?

@fuzetsu
Copy link
Author

fuzetsu commented Mar 24, 2024

Thanks! Tried out latest master but now I'm seeing no image at all (in all terminals).

I just cloned the repo and used cargo run.

@aome510
Copy link
Owner

aome510 commented Mar 24, 2024

Thanks! Tried out latest master but now I'm seeing no image at all (in all terminals).

I just cloned the repo and used cargo run.

should be cargo run --features image.

@fuzetsu
Copy link
Author

fuzetsu commented Mar 24, 2024

Just saw that 🤦

Thanks! Trying again.

@fuzetsu
Copy link
Author

fuzetsu commented Mar 24, 2024

Seems to be fixed now! Also fixed some weirdness with the top line of the help I noticed before.

Images are still a bit squeezed in kitty though, I'm now thinking it might be a config issue on my side though because of line height 🤔

image

@fuzetsu
Copy link
Author

fuzetsu commented Mar 24, 2024

Hmm, yeah looks fine with other fonts. My problem then I guess 😆
image

@n-ameless
Copy link

image
image
still occuring on 0.17.2 for me

@aome510
Copy link
Owner

aome510 commented Apr 4, 2024

image image still occuring on 0.17.2 for me

Is this behaviour consistent? What terminal are you using?

@n-ameless
Copy link

This behavior is consistent on Kitty terminal on NixOS. Using latest kitty and spotify-player on nixpkgs unstable.

@icep0ps
Copy link

icep0ps commented Jun 5, 2024

I was having the same problem, I kind of fixed this by adding the following to the app.toml

cover_img_length = 12
cover_img_width = 5

@diegoulloao
Copy link

I was having the same problem, I kind of fixed this by adding the following to the app.toml

cover_img_length = 12
cover_img_width = 5

same issue, it depends of the line height you're using, you can play with the cover_img_length value till the image is squared

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants