Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor client request handling module #418

Merged
merged 6 commits into from
Apr 20, 2024
Merged

Refactor client request handling module #418

merged 6 commits into from
Apr 20, 2024

Conversation

aome510
Copy link
Owner

@aome510 aome510 commented Apr 20, 2024 •
edited
Loading

Resolves #415

Changes

  • update player's playback state upon receiving new player event from the integrated client
  • move ClientRequest and PlayerRequest from event module to client::request module
  • clean up client request handling codes, update comments/documentations

@aome510 aome510 merged commit f37a9d2 into master Apr 20, 2024
3 checks passed
@aome510 aome510 mentioned this pull request Apr 20, 2024
Closed
@aome510 aome510 deleted the handle-player-events branch April 21, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"spotify_player get key playback" sometimes returns outdated information
1 participant
@aome510