skip single selection for artist actions #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aNNiMON
force-pushed
the
skip-single-selection
branch
2 times, most recently
from
c63ef30 to
ea2f809
Compare
aome510
approved these changes
Jul 19, 2024
spotify_player/src/event/mod.rs
Outdated
| album.artists, | ||
| new_list_state(), | ||
| )); | ||
| self::handle_show_actions_on_artist(album.artists, data, ui); |
There was a problem hiding this comment.
Suggested change
| self::handle_show_actions_on_artist(album.artists, data, ui); | |
| handle_show_actions_on_artist(album.artists, data, ui); |
There was a problem hiding this comment.
Done. I wonder why CI doesn't detect it?
aNNiMON
force-pushed
the
skip-single-selection
branch
from
ea2f809 to
79394d2
Compare
aome510
reviewed
Jul 19, 2024
aNNiMON
force-pushed
the
skip-single-selection
branch
from
79394d2 to
86ca9f0
Compare
aNNiMON
force-pushed
the
skip-single-selection
branch
from
86ca9f0 to
39c3764
Compare
DOD-101
pushed a commit
to DOD-101/spotify-player
that referenced
this pull request
Jul 19, 2024
juliamertz
pushed a commit
to juliamertz/spotify-player
that referenced
this pull request
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since most tracks are performed by a single artist, I found it a bit annoying to always select an artist when using the
GoToArtistandShowActionsOnArtistactions.