Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: target configuration for action keymaps #539

Merged
merged 6 commits into from
Aug 18, 2024

Conversation

juliamertz
Copy link
Contributor

Actually fixes #428 this time 🙃

update doc

fix clippy warnings

clean up
fix format
Copy link
Owner

@aome510 aome510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I left a few comments other looks good.

spotify_player/src/config/keymap.rs Outdated Show resolved Hide resolved
spotify_player/src/event/page.rs Outdated Show resolved Hide resolved
spotify_player/src/event/mod.rs Outdated Show resolved Hide resolved
spotify_player/src/event/mod.rs Outdated Show resolved Hide resolved
@juliamertz
Copy link
Contributor Author

juliamertz commented Aug 18, 2024

Should all be fixed now

@aome510 aome510 merged commit 463a16c into aome510:master Aug 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remap key to key combination
2 participants