feat: client_id_cmd config option #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleanup function doc
aome510
reviewed
Aug 17, 2024
spotify_player/src/config/mod.rs
Outdated
Comment on lines
395
to
404
| let output = if cfg!(target_os = "windows") { | ||
| std::process::Command::new("cmd") | ||
| .args(["/C", &cmd]) | ||
| .output() | ||
| } else { | ||
| std::process::Command::new("sh") | ||
| .arg("-c") | ||
| .arg(&cmd) | ||
| .output() | ||
| }?; |
There was a problem hiding this comment.
Should we use config::Command struct to represent this for consistency (e.g. with previous player_event_hook_command)? See
spotify-player/spotify_player/src/config/mod.rs
Lines 138 to 142 in c3e9a4e
I guess specifying a command string is more convenient, but the above code looks kinda "hacky" to me.
There was a problem hiding this comment.
Ah I didn't know this existed in the codebase, this does seem like a better idea.
I could pull out the execution logic for player_event_hook_command and implement that on the Command struct
aome510
reviewed
Aug 17, 2024
Co-authored-by: Thang Pham <phamducthang1234@gmail.com>
aome510
approved these changes
Aug 17, 2024
Co-authored-by: Thang Pham <phamducthang1234@gmail.com>
|
I learn new things about this language every day, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #537 by adding a new config option
client_id_cmd. When set, it will run this command and use its stdout as the client_id. I haven't been able to verify it's working on Windows, but that part has been copied from the rust docs so it should be fine.