Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update layout of library and search pages for vertical aspect ratios #559

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

juliamertz
Copy link
Contributor

I've chosen a columns to rows ratio that works well for me, but I'm not sure if this is the best approach since terminal rendering varies.

@juliamertz
Copy link
Contributor Author

weird, clippy didn't fail for me locally

Copy link
Owner

@aome510 aome510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review and thank you for the PR. I tested it. Really cool feature!

@juliamertz
Copy link
Contributor Author

No worries, thank you for taking the time!

@aome510 aome510 merged commit 80006c6 into aome510:master Oct 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants