audio: migrate back to yukawa HAL #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does the initial move to the newly "generic" yukawa audio HAL. The HAL supports loading the mixer_paths.xml file based on some runtime property (vendor.hw), this is used for dragonboard where the db845c and rb5 use the same lunch target. However because we use different lunch targets I've hardcoded vendor.hw to "sdm845", the mixer_paths.xml is packaged from the device specific directory to /vendor/etc/mixer_paths.sdm845.xml. This depends on a new patch to system/media/ to support specifying the output device in the mixer paths xml file: https://android-review.googlesource.com/c/platform/system/media/+/2036767 I'll update our local_manifests to include this change in the mean time before it's merged. The beryllium and axolotl mixer paths are basically placeholder and will need to be fixed. The enchilada paths *should* work, but for some reason the speaker is broken, I suspect a kernel issue here. Headphone detection and auto-switching works, on enchilada I'm able to hear audio through headphones. Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
calebccff
force-pushed
the
yukawa_generic_audio
branch
from
cb94501
to
9bd7f5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the initial move to the newly "generic" yukawa audio HAL.
The HAL supports loading the mixer_paths.xml file based on some runtime
property (vendor.hw), this is used for dragonboard where the db845c and
rb5 use the same lunch target. However because we use different lunch
targets I've hardcoded vendor.hw to "sdm845", the mixer_paths.xml is
packaged from the device specific directory to
/vendor/etc/mixer_paths.sdm845.xml.
This depends on a new patch to system/media/ to support specifying the
output device in the mixer paths xml file:
https://android-review.googlesource.com/c/platform/system/media/+/2036767
I'll update our local_manifests to include this change in the mean time
before it's merged.
The beryllium and axolotl mixer paths are basically placeholder and will
need to be fixed. The enchilada paths should work, but for some reason
the speaker is broken, I suspect a kernel issue here. Headphone
detection and auto-switching works, on enchilada I'm able to hear audio
through headphones.
The work to make it generic can be found here: https://android-review.googlesource.com/c/device/linaro/dragonboard/+/2042597
Once this is accepted into AOSP we can drop the HAL from our repo and instead build it from there.