Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for OnePlus 6T #16

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add Support for OnePlus 6T #16

wants to merge 4 commits into from

Conversation

J0SH1X
Copy link

@J0SH1X J0SH1X commented Jul 13, 2022

This commit adds support for Oneplus 6T (fajita), it adds boardconfig files aswell as a new kernel with support for the tfa98xx module provided in my GitHub repo https://github.com/j0sh1x/tfa98xx.git

@J0SH1X
Copy link
Author

J0SH1X commented Jul 13, 2022

the kernel source doesn't differ I just had to rebuild it for the module to load properly without hacks

@calebccff
Copy link
Collaborator

Thanks for this PR.

please note the current expectation here is that users compile their own kernels.

we also don't host firmware under this namespace.

can you make this a single commit to add the board files, drop the kernel changes and firmware.

@J0SH1X
Copy link
Author

J0SH1X commented Jul 13, 2022

changed it to only add board support files

@calebccff
Copy link
Collaborator

Awesome, let me know when you've validated it and I'll merge this.

@sc-ah
Copy link

sc-ah commented Jul 14, 2022

validation failed :/

device starts into a black screen and then reboots

@calebccff
Copy link
Collaborator

This matches my experience with it. I suspect a bug in the display panel driver.

@sc-ah
Copy link

sc-ah commented Jul 14, 2022

i will try to add some code to force crashdump mode into panel driver and see if i can provide any logs without uart , i dont wanna open my device

@sc-ah
Copy link

sc-ah commented Jul 14, 2022

also i was told if this code wont crash into crashdump but keeps running me may can get EL2 access

@calebccff
Copy link
Collaborator

It's worth giving this a go, I've had a lot of success getting logs this way: https://wiki.postmarketos.org/wiki/Serial_debugging/Serial_Gadget

@J0SH1X
Copy link
Author

J0SH1X commented Jul 14, 2022

it looks like its caused by something in aosp.config if i compile the kernel only with sdm845.config it boots to no rootfs panic if i then recompile for android i get the same behaviour that the log cuts off and the device reboots

@calebccff
Copy link
Collaborator

Can you include the log please?

@sc-ah
Copy link

sc-ah commented Jul 15, 2022

The device doesnt print out logs only if the kernel is bootstrapped with edk2 i can get some kind of on screen log but thats not very usefull

@calebccff
Copy link
Collaborator

Did you try my suggestion of using the USB serial gadget to get logs via USB?

@calebccff
Copy link
Collaborator

Also, stop using edk2, it makes it harder to reproduce whatever issues you're having. just flash to the boot partition as normal

@J0SH1X
Copy link
Author

J0SH1X commented Jul 25, 2022

managed to get a serial device shown but its rebooting so quickly I can't grab any logs I will try with my linux machine again , rn im using my work Mac

@J0SH1X
Copy link
Author

J0SH1X commented Jul 25, 2022

this doesn't seem to work as the device reboots just too fast

@J0SH1X
Copy link
Author

J0SH1X commented Jul 25, 2022

finally got it to work on a linux machine

https://gist.github.com/J0SH1X/72df7652d110e559333edc91230190c6

@J0SH1X
Copy link
Author

J0SH1X commented Jul 25, 2022

it looks like the fstab and init scripts are not beeing copied over properly

@J0SH1X
Copy link
Author

J0SH1X commented Jul 25, 2022

device reaches init now and doesnt reboot anymore display is dead cause of a missing firmware file

will continue debugging later

@@ -30,6 +30,7 @@ on early-boot
chown graphics graphics /sys/kernel/debug/sync/sw_sync
chmod 777 /sys/kernel/debug/sync/sw_sync
chown graphics graphics /sys/kernel/debug/sync/info
setprop sys.use_memfd true
Copy link
Collaborator

@calebccff calebccff Jul 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is actually needed, memfd is used as a fallback by default and d7cdfec fixes support for it.

@pundiramit can you clarify?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you don't add ashmem driver back into kernel its needed else surfaceflinger keeps crashing with ashmem driver added back its not needed

Copy link
Collaborator

@calebccff calebccff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop the merge commit

Edit: and squash the top two commits into one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants