Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make memfd switch optional #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

pundiramit
Copy link
Collaborator

Some devices (e.g. beryllium) still prefer to stick to Ashmem for now, mostly to keep selinux in enforcing mode.

Some devices (e.g. beryllium) still prefer to stick to Ashmem
for now, mostly to keep selinux in enforcing mode.

Signed-off-by: Amit Pundir <amit.pundir@linaro.org>
@pundiramit
Copy link
Collaborator Author

@amartinz @calebccff @vknecht @lweiss-fairphone please smoke test on your respective devices and let me know your thoughts on this one.

@z3ntu
Copy link

z3ntu commented Sep 14, 2022

(@lweiss-fairphone is my other account btw) I've also patched ashmem back into my kernel, to keep selinux enforcing; and my device is anyways not supported in this branch

@amartinz
Copy link
Contributor

axolotl does not work properly when using memfd and i had to disable it locally to get the version for the demo up and running.

That's why i would prefer if axolotl would stick to ashmem as well, especially because of selinux.

I think we should revert memfd for all devices and reenable once we have all the pieces (including proper sepolicies) in place?

@calebccff
Copy link
Collaborator

I've been using android-mainline with ashmem, so i don't really mind. reverting seems sensible for enchilada too right now

@amartinz
Copy link
Contributor

In any case, smoke tested with axolotl and it works:

axolotl:/ $ getprop | grep memfd
[sys.use_memfd]: [true]
axolotl:/ $ getenforce                                                                                                                                                                                                                                                                                                       
Permissive

(seems memfd issues are gone now and i just had a bad sync last time).

@pundiramit

This comment was marked as off-topic.

@MarijnS95

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants