Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #70; Add CLI option --error-utf8 #72

Merged
merged 3 commits into from
Dec 12, 2021
Merged

Fix #70; Add CLI option --error-utf8 #72

merged 3 commits into from
Dec 12, 2021

Conversation

takahashim
Copy link
Contributor

@takahashim takahashim commented Dec 12, 2021

#70 に対応して、--error-utf8オプションをつけるとエラーメッセージがUTF-8になるようにします。

現状I18n.tはエラーメッセージ出力用にしか使ってないため、上記オプションでI18nクラス全体のエンコーディング設定がUTF-8になるようにしています。
将来的に必要になればI18n.t(msg, encoding: 'Shift_JIS')みたいな18nの設定を無視してエンコーディングを指定するキーワード引数を追加すると良さそうです。

@takahashim takahashim merged commit c089fa8 into master Dec 12, 2021
@takahashim takahashim deleted the error-utf8 branch December 12, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant