This repository has been archived by the owner on Jan 9, 2020. It is now read-only.
Explicitly disable "waiting for app completion" behavior for the integration tests #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the example job are patched to never finish.
lins05
changed the title
|
Yep - the alternative is to run |
|
Great, merging then! |
|
Thanks @lins05 for the fix! |
ash211
pushed a commit
that referenced
this pull request
Feb 8, 2017
Since the example job are patched to never finish.
ash211
pushed a commit
that referenced
this pull request
Mar 8, 2017
Since the example job are patched to never finish.
foxish
pushed a commit
that referenced
this pull request
Jul 24, 2017
Since the example job are patched to never finish.
ifilonenko
pushed a commit
to ifilonenko/spark
that referenced
this pull request
Feb 25, 2019
…k8s#84) Since the example job are patched to never finish.
puneetloya
pushed a commit
to puneetloya/spark
that referenced
this pull request
Mar 11, 2019
…k8s#84) Since the example job are patched to never finish.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In this PR the we explicitly disable "waiting for app completion" behavior for the integration tests.
The spark example job in the integration tests is patched to never get finished, so the test code could have enough time to inspect the running job status. But in #53 we changed the default submit behavior to be blocking waiting for the app to finish. This leads to the integration tests getting stuck infinitely.
How was this patch tested?
Running the integration tests.