fix: remove/clarify comments

apache-superset · May 9, 2019 · 676ba71 · 676ba71
1 parent 211c4c6
commit 676ba71
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 15 deletions.
diff --git a/packages/superset-ui-preset-chart-xy/src/ScatterPlot/ScatterPlot.tsx b/packages/superset-ui-preset-chart-xy/src/ScatterPlot/ScatterPlot.tsx
@@ -87,21 +87,6 @@ export default class ScatterPlot extends PureComponent<Props> {
       data: d,
     }));
 
-    // if (typeof channels.x.scale !== 'undefined') {
-    //   const xDomain = d3Extent(encodedData, d => d.x);
-    //   const [min, max] = xDomain;
-    //   const adjustedDomain = [Math.min(min || 0, 0), Math.max(max || 1, 1)];
-    //   // channels.x.scale.setDomain(adjustedDomain);
-    //   // channels.x.definition.scale.domain = adjustedDomain;
-    // }
-    // if (typeof channels.y.scale !== 'undefined') {
-    //   const yDomain = d3Extent(encodedData, d => d.y);
-    //   const [min, max] = yDomain;
-    //   const adjustedDomain = [Math.min(min || 0, 0), Math.max(max || 1, 1)];
-    //   // channels.y.scale.setDomain(adjustedDomain);
-    //   // channels.y.definition.scale.domain = adjustedDomain;
-    // }
-
     const children = [
       <PointSeries
         key={channels.x.definition.field}

diff --git a/packages/superset-ui-preset-chart-xy/src/ScatterPlot/legacy/transformProps.ts b/packages/superset-ui-preset-chart-xy/src/ScatterPlot/legacy/transformProps.ts
@@ -21,11 +21,13 @@ export default function transformProps(chartProps: ChartProps) {
     x,
     xAxisFormat,
     xAxisLabel,
+    // TODO: These fields are not supported yet
     // xAxisShowminmax,
     // xLogScale,
     y,
     yAxisLabel,
     yAxisFormat,
+    // TODO: These fields are not supported yet
     // yAxisShowminmax,
     // yLogScale,
   } = formData;