Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

fix(legacy-table): avoid React DOM #392

Merged
merged 9 commits into from
Mar 9, 2020

Commits on Mar 7, 2020

  1. fix(legacy-table): avoid React DOM

    `jquery.datatables` will manipulate DOMs, sometimes remove them. In case
    of component being reloaded with updated props, React will not be able
    to find those removed nodes, causing a `cannot removeChild` error.
    
    Because of the the way to assign row keys, if table shape changes (add
    or remove columns), React may also have difficulty match the cached
    nodes via keys.
    
    In general it's a bad idea to directly manipulate React rendered DOM
    nodes, so we better just let `jquery.datatables` handle everything.
    
    In the future, once we removed `jquery.datatables`, a pure React
    component will not have such issues.
    ktmud committed Mar 7, 2020
    Configuration menu
    Copy the full SHA
    2351369 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    623f4cf View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0e95808 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2020

  1. refactor: use nimbus build

    ktmud committed Mar 8, 2020
    Configuration menu
    Copy the full SHA
    a6701b5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cdaf494 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2f25555 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. Configuration menu
    Copy the full SHA
    c8a58c9 View commit details
    Browse the repository at this point in the history
  2. chore(legacy-table): clean up tests case setups

    Not seeing the console.warn errors anymore. So cleaning it up.
    
    Previously it was from `<SuperChart />` component, but since we have
    updated the test case to not use <SuperChart>, we are good now.
    ktmud committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    933c3f9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b7596d0 View commit details
    Browse the repository at this point in the history