This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
Commits on Mar 7, 2020
-
fix(legacy-table): avoid React DOM
`jquery.datatables` will manipulate DOMs, sometimes remove them. In case of component being reloaded with updated props, React will not be able to find those removed nodes, causing a `cannot removeChild` error. Because of the the way to assign row keys, if table shape changes (add or remove columns), React may also have difficulty match the cached nodes via keys. In general it's a bad idea to directly manipulate React rendered DOM nodes, so we better just let `jquery.datatables` handle everything. In the future, once we removed `jquery.datatables`, a pure React component will not have such issues.
Configuration menu - View commit details
-
Copy full SHA for 2351369 - Browse repository at this point
Copy the full SHA 2351369View commit details -
Configuration menu - View commit details
-
Copy full SHA for 623f4cf - Browse repository at this point
Copy the full SHA 623f4cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e95808 - Browse repository at this point
Copy the full SHA 0e95808View commit details
Commits on Mar 8, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a6701b5 - Browse repository at this point
Copy the full SHA a6701b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdaf494 - Browse repository at this point
Copy the full SHA cdaf494View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f25555 - Browse repository at this point
Copy the full SHA 2f25555View commit details
Commits on Mar 9, 2020
-
Configuration menu - View commit details
-
Copy full SHA for c8a58c9 - Browse repository at this point
Copy the full SHA c8a58c9View commit details -
chore(legacy-table): clean up tests case setups
Not seeing the console.warn errors anymore. So cleaning it up. Previously it was from `<SuperChart />` component, but since we have updated the test case to not use <SuperChart>, we are good now.
Configuration menu - View commit details
-
Copy full SHA for 933c3f9 - Browse repository at this point
Copy the full SHA 933c3f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7596d0 - Browse repository at this point
Copy the full SHA b7596d0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.