fix: address comments

apache-superset · Apr 27, 2020 · a91a127 · a91a127
1 parent 967da8f
commit a91a127
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 7 deletions.
diff --git a/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-word-cloud/Stories.tsx b/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-word-cloud/Stories.tsx
@@ -1,6 +1,6 @@
 import React from 'react';
 import { SuperChart } from '@superset-ui/chart';
-import { select } from '@storybook/addon-knobs';
+import { select, withKnobs } from '@storybook/addon-knobs';
 import WordCloudChartPlugin from '@superset-ui/plugin-chart-word-cloud';
 import LegacyWordCloudChartPlugin from '@superset-ui/plugin-chart-word-cloud/esm/legacy';
 import data from './data';
@@ -10,6 +10,7 @@ new LegacyWordCloudChartPlugin().configure({ key: 'legacy-word-cloud2' }).regist
 
 export default {
   title: 'Chart Plugins|plugin-chart-word-cloud',
+  decorators: [withKnobs],
 };
 
 export const basic = () => (
@@ -78,7 +79,6 @@ export const encodesColorByWordLength = () => (
   />
 );
 
-
 export const encodesFontByFirstLetter = () => (
   <SuperChart
     chartType="word-cloud2"

diff --git a/packages/superset-ui-demo/storybook/stories/plugins/preset-chart-xy/Line/Stories.tsx b/packages/superset-ui-demo/storybook/stories/plugins/preset-chart-xy/Line/Stories.tsx
@@ -1,11 +1,13 @@
 import { LineChartPlugin, LegacyLineChartPlugin } from '@superset-ui/preset-chart-xy';
 import { LINE_PLUGIN_TYPE, LINE_PLUGIN_LEGACY_TYPE } from './constants';
+import { withKnobs } from '@storybook/addon-knobs';
 
 new LegacyLineChartPlugin().configure({ key: LINE_PLUGIN_LEGACY_TYPE }).register();
 new LineChartPlugin().configure({ key: LINE_PLUGIN_TYPE }).register();
 
 export default {
   title: 'Chart Plugins|preset-chart-xy/Line',
+  decorators: [withKnobs],
 };
 
 export { default as basic } from './stories/basic';

diff --git a/packages/superset-ui-demo/storybook/stories/plugins/preset-chart-xy/ScatterPlot/Stories.tsx b/packages/superset-ui-demo/storybook/stories/plugins/preset-chart-xy/ScatterPlot/Stories.tsx
@@ -1,11 +1,13 @@
 import { ScatterPlotChartPlugin, LegacyScatterPlotChartPlugin } from '@superset-ui/preset-chart-xy';
 import { SCATTER_PLOT_PLUGIN_TYPE, SCATTER_PLOT_PLUGIN_LEGACY_TYPE } from './constants';
+import { withKnobs } from '@storybook/addon-knobs';
 
 new LegacyScatterPlotChartPlugin().configure({ key: SCATTER_PLOT_PLUGIN_LEGACY_TYPE }).register();
 new ScatterPlotChartPlugin().configure({ key: SCATTER_PLOT_PLUGIN_TYPE }).register();
 
 export default {
   title: 'Chart Plugins|preset-chart-xy/ScatterPlot',
+  decorators: [withKnobs],
 };
 
 export { default as basic } from './stories/basic';

diff --git a/packages/superset-ui-demo/storybook/stories/superset-ui-chart/SuperChartStories.tsx b/packages/superset-ui-demo/storybook/stories/superset-ui-chart/SuperChartStories.tsx
@@ -13,7 +13,7 @@ new BuggyChartPlugin().configure({ key: ChartKeys.BUGGY }).register();
 const DEFAULT_QUERY_DATA = { data: ['foo', 'bar'] };
 
 export default {
-  title: 'Core Packages|@superset-ui/chart',
+  title: '*Core Packages|@superset-ui/chart',
   decorators: [withKnobs],
 };
 

diff --git a/packages/superset-ui-demo/storybook/stories/superset-ui-color/ColorPallettesStories.jsx b/packages/superset-ui-demo/storybook/stories/superset-ui-color/ColorPallettesStories.jsx
@@ -11,7 +11,7 @@ import SequantialD3Palettes from '@superset-ui/color/src/colorSchemes/sequential
 import RenderPalettes from './RenderPalettes';
 
 export default {
-  title: 'Core Packages|@superset-ui/color',
+  title: '*Core Packages|@superset-ui/color',
 };
 
 export const categoricalPalettes = () =>

diff --git a/packages/superset-ui-demo/storybook/stories/superset-ui-connection/ConnectionStories.tsx b/packages/superset-ui-demo/storybook/stories/superset-ui-connection/ConnectionStories.tsx
@@ -8,7 +8,7 @@ import Expandable from '../../shared/components/Expandable';
 const REQUEST_METHODS = ['GET', 'POST'];
 
 export default {
-  title: 'Core Packages|@superset-ui/connection',
+  title: '*Core Packages|@superset-ui/connection',
   decorators: [withKnobs],
 };
 

diff --git a/packages/superset-ui-demo/storybook/stories/superset-ui-number-format/BigNumberStories.jsx b/packages/superset-ui-demo/storybook/stories/superset-ui-number-format/BigNumberStories.jsx
@@ -116,7 +116,7 @@ NumberFormatValidator.propTypes = propTypes;
 NumberFormatValidator.defaultProps = defaultProps;
 
 export default {
-  title: 'Core Packages|@superset-ui/number-format',
+  title: '*Core Packages|@superset-ui/number-format',
 };
 
 export const validator = () => <NumberFormatValidator />;
diff --git a/packages/superset-ui-demo/storybook/stories/superset-ui-time-format/TimeFormatStories.jsx b/packages/superset-ui-demo/storybook/stories/superset-ui-time-format/TimeFormatStories.jsx
@@ -105,7 +105,7 @@ TimeFormatValidator.propTypes = propTypes;
 TimeFormatValidator.defaultProps = defaultProps;
 
 export default {
-  title: 'Core Packages|@superset-ui/time-format',
+  title: '*Core Packages|@superset-ui/time-format',
 };
 
 export const validator = () => <TimeFormatValidator />;