test: add unit tests

packages/superset-ui-validator/src/validateInteger.ts

@@ -2,7 +2,7 @@ import { t } from '@superset-ui/translation';
 
 export default function validateInteger(v: unknown) {
   if (
-    (typeof v === 'string' && Number.isInteger(Number(v))) ||
+    (typeof v === 'string' && v.trim().length > 0 && Number.isInteger(Number(v.trim()))) ||
     (typeof v === 'number' && Number.isInteger(v))
   ) {
     return false;

packages/superset-ui-validator/src/validateNumber.ts

@@ -2,7 +2,7 @@ import { t } from '@superset-ui/translation';
 
 export default function validateInteger(v: unknown) {
   if (
-    (typeof v === 'string' && Number.isFinite(Number(v))) ||
+    (typeof v === 'string' && v.trim().length > 0 && Number.isFinite(Number(v.trim()))) ||
     (typeof v === 'number' && Number.isFinite(v))
   ) {
     return false;

packages/superset-ui-validator/test/validateInteger.test.ts

@@ -8,6 +8,7 @@ describe('validateInteger()', () => {
     expect(validateInteger('')).toBeTruthy();
   });
   it('returns false if the input is valid', () => {
+    expect(validateInteger(0)).toBeFalsy();
     expect(validateInteger(10)).toBeFalsy();
     expect(validateInteger('10')).toBeFalsy();
   });

packages/superset-ui-validator/test/validateNonEmpty.test.ts

@@ -0,0 +1,15 @@
+import { validateNonEmpty } from '../src';
+
+describe('validateNonEmpty()', () => {
+  it('returns the warning message if invalid', () => {
+    expect(validateNonEmpty([])).toBeTruthy();
+    expect(validateNonEmpty(undefined)).toBeTruthy();
+    expect(validateNonEmpty(null)).toBeTruthy();
+    expect(validateNonEmpty('')).toBeTruthy();
+  });
+  it('returns false if the input is valid', () => {
+    expect(validateNonEmpty(0)).toBeFalsy();
+    expect(validateNonEmpty(10)).toBeFalsy();
+    expect(validateNonEmpty('abc')).toBeFalsy();
+  });
+});

packages/superset-ui-validator/test/validateNumber.test.ts

@@ -0,0 +1,15 @@
+import { validateNumber } from '../src';
+
+describe('validateNumber()', () => {
+  it('returns the warning message if invalid', () => {
+    expect(validateNumber(undefined)).toBeTruthy();
+    expect(validateNumber(null)).toBeTruthy();
+    expect(validateNumber('')).toBeTruthy();
+  });
+  it('returns false if the input is valid', () => {
+    expect(validateNumber(0)).toBeFalsy();
+    expect(validateNumber(10.1)).toBeFalsy();
+    expect(validateNumber(10)).toBeFalsy();
+    expect(validateNumber('10')).toBeFalsy();
+  });
+});

test/setup.ts

@@ -1,3 +1,7 @@
+import { configure } from '@superset-ui/translation';
+
+configure();
+
 const caches = {};
 
 class Cache {