Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(plugin-chart-table): check if control values are set #1095

Merged

Conversation

villebro
Copy link
Contributor

@villebro villebro commented May 6, 2021

🐛 Bug Fix
When checking for visibility of server side related controls, make sure the control value is set before reading the control value.

@villebro villebro requested a review from a team as a code owner May 6, 2021 06:42
@vercel
Copy link

vercel bot commented May 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/BaS5vWmVBkVJv4E4RM4kMgmSX28R
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-table-visibil-83dc82.vercel.app

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #1095 (34df7d4) into master (f9dec07) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1095   +/-   ##
=======================================
  Coverage   28.35%   28.35%           
=======================================
  Files         448      448           
  Lines        9057     9057           
  Branches     1423     1423           
=======================================
  Hits         2568     2568           
  Misses       6289     6289           
  Partials      200      200           
Impacted Files Coverage Δ
plugins/plugin-chart-table/src/controlPanel.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9dec07...34df7d4. Read the comment docs.

Copy link
Contributor

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit ebb4402 into apache-superset:master May 6, 2021
@villebro villebro deleted the villebro/table-visibility branch May 6, 2021 14:09
stephenLYZ pushed a commit to stephenLYZ/superset-ui that referenced this pull request May 6, 2021
stephenLYZ added a commit to stephenLYZ/superset-ui that referenced this pull request May 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants