Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(plugin-chart-echarts): set up orderby by default on Pie chart #1111

Merged
merged 1 commit into from
May 15, 2021

Conversation

xiezhongfu
Copy link
Contributor

@xiezhongfu xiezhongfu commented May 15, 2021

SORT BY METRIC checkbox check by default in Pie chart. so the query is:

SELECT value AS value,
       SUM(value) AS sum__value
FROM energy_usage
GROUP BY value
ORDER BY sum__value DESC
LIMIT 10000;

before

pie  sort by metric  after

after

pie  sort by metric  before

@vercel
Copy link

vercel bot commented May 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/FKs1BbjNg5peWWd1Say6uqfoWNft
✅ Preview: https://superset-ui-git-fork-xiezhongfu-piesortbymetric-superset.vercel.app

@codecov
Copy link

codecov bot commented May 15, 2021

Codecov Report

Merging #1111 (8f439e5) into master (9e89c9e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1111   +/-   ##
=======================================
  Coverage   28.98%   28.98%           
=======================================
  Files         462      462           
  Lines        9202     9202           
  Branches     1449     1449           
=======================================
  Hits         2667     2667           
  Misses       6333     6333           
  Partials      202      202           
Impacted Files Coverage Δ
...gins/plugin-chart-echarts/src/Pie/controlPanel.tsx 33.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e89c9e...8f439e5. Read the comment docs.

@xiezhongfu xiezhongfu marked this pull request as ready for review May 15, 2021 11:23
@xiezhongfu xiezhongfu requested a review from a team as a code owner May 15, 2021 11:23
@xiezhongfu xiezhongfu changed the title feat(plugin-chart-echarts): sort by metric checkbox check by default feat(plugin-chart-echarts): sort by metric checkbox check by default for Pie May 15, 2021
@zhaoyongjie zhaoyongjie changed the title feat(plugin-chart-echarts): sort by metric checkbox check by default for Pie feat(plugin-chart-echarts): set up orderby by default on Pie chart May 15, 2021
Copy link
Contributor

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 99b5665 into apache-superset:master May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants