Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: 🎸 add .clone() function to ChartMetadata #112

Merged
merged 3 commits into from
Feb 28, 2019
Merged

feat: 🎸 add .clone() function to ChartMetadata #112

merged 3 commits into from
Feb 28, 2019

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Feb 27, 2019

🏆 Enhancements

  • add .clone() function to ChartMetadata

@kristw kristw requested a review from a team as a code owner February 27, 2019 22:28
@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #112 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #112   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          73     73           
  Lines         888    890    +2     
  Branches      204    204           
=====================================
+ Hits          888    890    +2
Impacted Files Coverage Δ
...ages/superset-ui-chart/src/models/ChartMetadata.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f57b995...5ea9893. Read the comment docs.

@kristw kristw added #enhancement New feature or request reviewable Ready for review labels Feb 27, 2019
@kristw kristw merged commit 1c1ef3b into master Feb 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--clone branch February 28, 2019 18:36
kristw added a commit that referenced this pull request Apr 17, 2020
@kristw
feat: allow overriding ChartLegend, its style and LegendGroup style (#…
105cf0f 
…112)

* feat: support overriding maximum legend height and legend item alignment

* feat: allow overriding ChartLegend, its style and LegendGroup style
@xiezhongfu xiezhongfu mentioned this pull request May 17, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
#enhancement New feature or request reviewable Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kristw @williaster