-
Notifications
You must be signed in to change notification settings - Fork 272
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/4pCDiFvhpq5tyanAixgeKEAbfWVu |
@suddjian is this a breaking change we change the name of a feature flag? |
Codecov Report
@@ Coverage Diff @@
## master #1178 +/- ##
=======================================
Coverage 29.01% 29.01%
=======================================
Files 463 463
Lines 9338 9338
Branches 1493 1493
=======================================
Hits 2709 2709
Misses 6418 6418
Partials 211 211
Continue to review full report at Codecov.
|
IMO this should be considered a breaking change (see SIP 57). It could be made a non-breaking change if measures are taken to make it so that the old name still works. |
@suddjian currently only one place in superset is using this featureFlag, and it is the database connection ui. |
@AAfghahi I would recommend adding the new flag instead of changing the name. You can remove the old flag later- mark that it is deprecated. |
The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: apache/superset#13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this PR on the main repo, which should be as simple as moving over any code changes as follows:
If you need help with the migration, please post a message on the SIP or reach out on the community Slack. |
💔 Breaking Changes
🏆 Enhancements
📜 Documentation
🐛 Bug Fix
🏠 Internal
Changing the name to better reflect what the feature flag is doing.