This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix(chart): import types from package, not monorepo #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 76 76
Lines 965 965
Branches 232 232
=====================================
Hits 965 965
Continue to review full report at Codecov.
|
kristw
reviewed
Mar 22, 2019
| @@ -1,6 +1,6 @@ | |||
| /* eslint react/sort-comp: 'off' */ | |||
| import React, { ReactNode } from 'react'; | |||
| import { SupersetClientInterface, RequestConfig } from '../../../superset-ui-connection/src/types'; | |||
| import { SupersetClientInterface, RequestConfig } from '@superset-ui/connection/lib/types'; | |||
There was a problem hiding this comment.
Would this work?
import { SupersetClientInterface, RequestConfig } from '@superset-ui/connection';There was a problem hiding this comment.
I'll try this, it's giving a TS error locally / can't find the declaration file 🤔
kristw
approved these changes
Mar 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix 🏠 Internal
This PR
fixes an import in
@superset-ui/chartthat should be from a package, not the monorepo. this caused the build to include additional directories in0.10.5and0.10.6. I confirmed that these directories are no longer generated after the fix.adds a flag to the
buildnpmscripts to delete the out directory, to ensure that deleted files and directories are not included in new releases.