This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
feat: getter function to return color mapping #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. waiting for ci |
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 76 76
Lines 965 970 +5
Branches 232 232
=====================================
+ Hits 965 970 +5
Continue to review full report at Codecov.
|
kristw
approved these changes
Mar 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
Exposed a getter function to return the color mapping between a data value and a color hex code. This is needed so we can save it as dashboard metadata for color consistency in dashboards (apache/superset#7086).