Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(plugin-chart-pivot-table): make date formatting clearable #1261

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

kgabryje
Copy link
Contributor

@kgabryje kgabryje commented Aug 2, 2021

Before there was no way to disable date formatting to see the original value of temporal column in pivot table. This PR enables clearing the select button value.

Screen.Recording.2021-08-02.at.18.00.12.mov

Fixes apache/superset#15947

CC @junlincc @jinghua-qa

@kgabryje kgabryje requested a review from a team as a code owner August 2, 2021 16:04
@vercel
Copy link

vercel bot commented Aug 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/EsNmyxJ9rr5hWGesYvP6A7CJU6zG
✅ Preview: https://superset-ui-git-fork-kgabryje-fix-pivot-clear-time-superset.vercel.app

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #1261 (4470712) into master (8012a6c) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1261   +/-   ##
=======================================
  Coverage   30.04%   30.04%           
=======================================
  Files         476      476           
  Lines        9666     9669    +3     
  Branches     1596     1598    +2     
=======================================
+ Hits         2904     2905    +1     
  Misses       6538     6538           
- Partials      224      226    +2     
Impacted Files Coverage Δ
...lugin-chart-pivot-table/src/plugin/controlPanel.ts 12.50% <ø> (ø)
...ins/plugin-chart-echarts/src/Tree/controlPanel.tsx 50.00% <0.00%> (-10.00%) ⬇️
...et-ui-chart-controls/src/shared-controls/index.tsx 36.45% <0.00%> (-0.39%) ⬇️
...chart-controls/src/shared-controls/dndControls.tsx 38.88% <0.00%> (+1.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8012a6c...4470712. Read the comment docs.

@kgabryje kgabryje merged commit d9eb8ce into apache-superset:master Aug 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pivot table v2] no remove button for DATE format
2 participants