Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(plugin-chart-pivot-table): add automatic conditional formatter #1264

Merged

Conversation

villebro
Copy link
Contributor

@villebro villebro commented Aug 3, 2021

🏆 Enhancements

Add a new conditional formatting operator to enable automatic formatting. This is a non-breaking change, as it only adds support for a new option.

SCREENSHOT

image

@villebro villebro requested a review from a team as a code owner August 3, 2021 08:22
@vercel
Copy link

vercel bot commented Aug 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/2FdtXXRUubemUFckx4tdv9hoz1vf
✅ Preview: https://superset-ui-git-fork-preset-io-villebro-auto-co-5f770f-superset.vercel.app

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #1264 (06f5a0c) into master (b1d8e0f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
+ Coverage   30.04%   30.08%   +0.04%     
==========================================
  Files         476      476              
  Lines        9669     9675       +6     
  Branches     1598     1600       +2     
==========================================
+ Hits         2905     2911       +6     
  Misses       6538     6538              
  Partials      226      226              
Impacted Files Coverage Δ
packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...-ui-chart-controls/src/utils/getColorFormatters.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1d8e0f...06f5a0c. Read the comment docs.

Copy link
Contributor

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@villebro villebro merged commit 02ede8a into apache-superset:master Aug 3, 2021
@villebro villebro deleted the villebro/auto-cond-formatting branch August 3, 2021 11:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants