Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: Show tooltip conditionally and pass ref down #1271

Merged
merged 4 commits into from
Aug 4, 2021
Merged

chore: Show tooltip conditionally and pass ref down #1271

merged 4 commits into from
Aug 4, 2021

Conversation

geido
Copy link
Member

@geido geido commented Aug 4, 2021

SUMMARY

This PR allows showing the tooltip conditionally as well as passing down the ref.

IMPORTANT

Required to be merged first to enable PR apache/superset#16060

@geido geido requested a review from a team as a code owner August 4, 2021 13:57
@vercel
Copy link

vercel bot commented Aug 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/D5RkWcAmcgoTj9HHY3YVg47jTVD8
✅ Preview: https://superset-ui-git-fork-geido-fix-issue15996-superset.vercel.app

Copy link
Contributor

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I look forward to this 👍

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #1271 (760a430) into master (ec7b2f3) will increase coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1271      +/-   ##
==========================================
+ Coverage   30.04%   30.08%   +0.03%     
==========================================
  Files         476      485       +9     
  Lines        9669     9730      +61     
  Branches     1598     1613      +15     
==========================================
+ Hits         2905     2927      +22     
- Misses       6538     6575      +37     
- Partials      226      228       +2     
Impacted Files Coverage Δ
...-ui-chart-controls/src/components/ColumnOption.tsx 76.92% <50.00%> (-13.08%) ⬇️
...-ui-chart-controls/src/components/MetricOption.tsx 55.55% <50.00%> (-0.70%) ⬇️
plugins/plugin-chart-table/src/TableChart.tsx 41.12% <0.00%> (-1.02%) ⬇️
...onents/ColumnConfigControl/ColumnConfigControl.tsx 2.17% <0.00%> (-0.46%) ⬇️
plugins/plugin-chart-table/src/controlPanel.tsx 0.00% <0.00%> (ø)
packages/superset-ui-chart-controls/src/types.ts 100.00% <0.00%> (ø)
...s/plugin-chart-pivot-table/src/PivotTableChart.tsx 0.00% <0.00%> (ø)
...lugin-chart-pivot-table/src/plugin/controlPanel.ts 12.50% <0.00%> (ø)
...-ui-chart-controls/src/utils/getColorFormatters.ts 100.00% <0.00%> (ø)
...trols/components/ColumnConfigControl/constants.tsx 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec7b2f3...760a430. Read the comment docs.

@geido geido merged commit db70042 into apache-superset:master Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants