-
Notifications
You must be signed in to change notification settings - Fork 272
chore: Show tooltip conditionally and pass ref down #1271
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/D5RkWcAmcgoTj9HHY3YVg47jTVD8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I look forward to this 👍
Codecov Report
@@ Coverage Diff @@
## master #1271 +/- ##
==========================================
+ Coverage 30.04% 30.08% +0.03%
==========================================
Files 476 485 +9
Lines 9669 9730 +61
Branches 1598 1613 +15
==========================================
+ Hits 2905 2927 +22
- Misses 6538 6575 +37
- Partials 226 228 +2
Continue to review full report at Codecov.
|
SUMMARY
This PR allows showing the tooltip conditionally as well as passing down the ref.
IMPORTANT
Required to be merged first to enable PR apache/superset#16060