Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: Hide Safari default tooltip #1283

Merged
merged 4 commits into from
Aug 10, 2021
Merged

fix: Hide Safari default tooltip #1283

merged 4 commits into from
Aug 10, 2021

Conversation

geido
Copy link
Member

@geido geido commented Aug 9, 2021

SUMMARY

This PR implements a small hack to prevent Safari from showing its default tooltip when a text is truncated and a custom Antdesign tooltip is already present.

RELATED PR ON SUPERSET

apache/superset#16145

BEFORE

Screen Shot 2021-08-09 at 16 50 59

AFTER

Screen Shot 2021-08-09 at 16 48 47

@geido geido requested a review from a team as a code owner August 9, 2021 14:54
@vercel
Copy link

vercel bot commented Aug 9, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/7Tp2o13AruTKvYYSMC3FPgzSpSJD
✅ Preview: https://superset-ui-git-fork-geido-fix-tooltipssafari-superset.vercel.app

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #1283 (19a9eb6) into master (8c645a1) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1283      +/-   ##
==========================================
- Coverage   30.05%   30.01%   -0.04%     
==========================================
  Files         485      485              
  Lines        9738     9794      +56     
  Branches     1615     1636      +21     
==========================================
+ Hits         2927     2940      +13     
- Misses       6583     6622      +39     
- Partials      228      232       +4     
Impacted Files Coverage Δ
...erset-ui-chart-controls/src/components/Tooltip.tsx 20.00% <0.00%> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 44.89% <0.00%> (-9.54%) ⬇️
...gin-chart-echarts/src/Timeseries/transformProps.ts 46.37% <0.00%> (-9.18%) ⬇️
plugins/plugin-chart-table/src/TableChart.tsx 38.23% <0.00%> (-2.90%) ⬇️
.../plugin-chart-table/src/utils/DateWithFormatter.ts 64.28% <0.00%> (-2.39%) ⬇️
...ackages/superset-ui-core/src/query/types/Filter.ts 100.00% <0.00%> (ø)
...ugins/plugin-chart-echarts/src/Timeseries/types.ts 100.00% <0.00%> (ø)
...s/legacy-plugin-chart-country-map/src/countries.ts 0.00% <0.00%> (ø)
...ugin-chart-echarts/src/Timeseries/controlPanel.tsx 40.00% <0.00%> (ø)
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 50.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c645a1...19a9eb6. Read the comment docs.

Copy link
Contributor

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@villebro villebro merged commit e50b25e into apache-superset:master Aug 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants