Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: add a note to the pivot plugin #1316

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

betodealmeida
Copy link
Contributor

🏠 Internal

We reproduce the logic of the pivot table viz in Python to produce nice reports. I added a note that if the logic of the plugin changes we need to update the Python logic.

@betodealmeida betodealmeida requested a review from a team as a code owner August 17, 2021 17:04
@vercel
Copy link

vercel bot commented Aug 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/Hyb4gxcZTvwYcQaHhe7rof422nks
✅ Preview: https://superset-ui-git-addnotepivotv2-superset.vercel.app

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #1316 (1889af6) into master (358733c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1316   +/-   ##
=======================================
  Coverage   29.93%   29.93%           
=======================================
  Files         487      487           
  Lines        9837     9837           
  Branches     1647     1647           
=======================================
  Hits         2945     2945           
  Misses       6656     6656           
  Partials      236      236           
Impacted Files Coverage Δ
...s/plugin-chart-pivot-table/src/PivotTableChart.tsx 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 358733c...1889af6. Read the comment docs.

@betodealmeida betodealmeida merged commit f09ef0c into master Aug 17, 2021
@delete-merged-branch delete-merged-branch bot deleted the add_note_pivot_v2 branch August 17, 2021 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants