Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(chart-controls): temporal col placeholder for hybrid dnd #1317

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

kgabryje
Copy link
Contributor

@kgabryje kgabryje commented Aug 18, 2021

If ENABLE_DND_WITH_CLICK_UX feature flag is enabled, change the Time Column placeholder from "Drop temporal column here" to "Drop a temporal column here or click"
Fixes apache/superset#16307

@kgabryje kgabryje requested a review from a team as a code owner August 18, 2021 07:41
@vercel
Copy link

vercel bot commented Aug 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/3RiyZBsFnJ5b7uAscbdwqUs4Pvoe
✅ Preview: https://superset-ui-git-fork-kgabryje-fix-temporal-placeholder-superset.vercel.app

@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #1317 (8f7178a) into master (ff2309a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
- Coverage   29.94%   29.93%   -0.02%     
==========================================
  Files         487      487              
  Lines        9840     9838       -2     
  Branches     1647     1648       +1     
==========================================
- Hits         2947     2945       -2     
+ Misses       6657     6656       -1     
- Partials      236      237       +1     
Impacted Files Coverage Δ
...chart-controls/src/shared-controls/dndControls.tsx 37.83% <0.00%> (-1.06%) ⬇️
...gin-chart-pivot-table/src/plugin/transformProps.ts 42.30% <0.00%> (-2.14%) ⬇️
...s/plugin-chart-pivot-table/src/PivotTableChart.tsx 0.00% <0.00%> (ø)
plugins/plugin-chart-table/src/transformProps.ts 62.79% <0.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff2309a...8f7178a. Read the comment docs.

@kgabryje kgabryje merged commit de13cb0 into apache-superset:master Aug 18, 2021
@henryyeh
Copy link

🏷️ 2021.31

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[d&d hybrid] place holder for temporal column
3 participants