Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: smartDateVerbose at seconds #132

Merged
merged 3 commits into from
Apr 8, 2019
Merged

fix: smartDateVerbose at seconds #132

merged 3 commits into from
Apr 8, 2019

Conversation

datability-io
Copy link
Contributor

@datability-io datability-io commented Apr 8, 2019 •
edited
Loading

🐛 Bug Fix

@datability-io datability-io requested a review from a team as a code owner April 8, 2019 19:10
kristw
kristw suggested changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@kristw kristw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert the version number

@codecov
Copy link

codecov bot commented Apr 8, 2019 •
edited
Loading

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #132   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          77     77           
  Lines         988    988           
  Branches      238    238           
=====================================
  Hits          988    988
Impacted Files Coverage Δ
...-ui-time-format/src/formatters/smartDateVerbose.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22ef4b1...c13d86a. Read the comment docs.

@xtinec xtinec merged commit d29bfd0 into apache-superset:master Apr 8, 2019
@datability-io datability-io deleted the improve_smartDateVerbose_at_seconds branch April 8, 2019 19:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xtinec xtinec xtinec left review comments

@kristw kristw kristw approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@datability-io @xtinec @kristw