Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix(plugin-chart-echarts): [gauge chart] filter indicator not be shown #1326

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

stephenLYZ
Copy link
Contributor

🐛 Bug Fix
refer to apache/superset#16255

after

2021-08-22.11.20.05.mov

@stephenLYZ stephenLYZ requested a review from a team as a code owner August 22, 2021 15:21
@vercel
Copy link

vercel bot commented Aug 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/13xteEvDJEjxtpSTJ3SWU1Trdjqf
✅ Preview: https://superset-ui-git-fork-stephenlyz-fix-gauge-chart-superset.vercel.app

@stephenLYZ stephenLYZ changed the title fix(plugin-chart-echarts): [guage chart] filter indicator not be shown fix(plugin-chart-echarts): [gauge chart] filter indicator not be shown Aug 22, 2021
@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #1326 (4cffd97) into master (80242f8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1326   +/-   ##
=======================================
  Coverage   30.02%   30.02%           
=======================================
  Files         487      487           
  Lines        9839     9839           
  Branches     1649     1649           
=======================================
  Hits         2954     2954           
  Misses       6647     6647           
  Partials      238      238           
Impacted Files Coverage Δ
plugins/plugin-chart-echarts/src/Gauge/index.ts 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80242f8...4cffd97. Read the comment docs.

@junlincc
Copy link
Contributor

thanks for the fix!! do you have the video for all "needles" are showing, and filtering/indicating work when clicking any of the needle? @stephenLYZ

Copy link
Contributor

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit ebdef50 into apache-superset:master Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants