-
Notifications
You must be signed in to change notification settings - Fork 272
chore: replace mathjs with mexp #1362
chore: replace mathjs with mexp #1362
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/6KH99irRgazeFsRjUDHHyAm89gkf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, just remove the console log please 🙂
a904749
to
5109096
Compare
Codecov Report
@@ Coverage Diff @@
## master #1362 +/- ##
==========================================
- Coverage 30.12% 30.12% -0.01%
==========================================
Files 491 491
Lines 9874 9878 +4
Branches 1662 1663 +1
==========================================
+ Hits 2975 2976 +1
- Misses 6652 6655 +3
Partials 247 247
Continue to review full report at Codecov.
|
🏠 Internal
Replace
mathjs
(11 Mb bundle) withmath-expression-evaluator
(71 kb) as done on apache/superset#16701.Checklist:
plugins-chart-echart
for formula evaluationNVD3 plugin after migration:
ECharts plugin after migration:
Also fix z-index of formula to make sure it is displayed above other charts:
AFTER
BEFORE