Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

refactor: improve code smell for postprocessing #1368

Merged
merged 3 commits into from
Sep 20, 2021

Conversation

zhaoyongjie
Copy link
Contributor

@zhaoyongjie zhaoyongjie commented Sep 20, 2021

🏆 Enhancements
No functional changes, some refactor for postprocessing. Added boxplotOperator, contributionOperator and prophetOperator.

@zhaoyongjie zhaoyongjie requested a review from a team as a code owner September 20, 2021 05:17
@vercel
Copy link

vercel bot commented Sep 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/9umBkf7ZqLkfuxtJcntRgm69YnJ6
✅ Preview: https://superset-ui-git-fork-zhaoyongjie-moveoperator-superset.vercel.app

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #1368 (e688034) into master (e48afb9) will increase coverage by 0.17%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1368      +/-   ##
==========================================
+ Coverage   30.18%   30.35%   +0.17%     
==========================================
  Files         492      495       +3     
  Lines        9886     9896      +10     
  Branches     1666     1666              
==========================================
+ Hits         2984     3004      +20     
+ Misses       6655     6648       -7     
+ Partials      247      244       -3     
Impacted Files Coverage Δ
...ins/plugin-chart-echarts/src/BoxPlot/buildQuery.ts 83.33% <0.00%> (+36.27%) ⬆️
plugins/plugin-chart-echarts/src/BoxPlot/types.ts 0.00% <ø> (ø)
.../plugin-chart-echarts/src/Timeseries/buildQuery.ts 50.00% <ø> (+25.00%) ⬆️
...ui-chart-controls/src/operators/boxplotOperator.ts 100.00% <100.00%> (ø)
...art-controls/src/operators/contributionOperator.ts 100.00% <100.00%> (ø)
...ui-chart-controls/src/operators/prophetOperator.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48afb9...e688034. Read the comment docs.

granularity: 'P1Y',
};

describe('boxplotOperator', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you avoid nesting tests? You can just use test on the top level.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

Copy link
Contributor

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for improving the code organization.

@zhaoyongjie zhaoyongjie merged commit dead812 into apache-superset:master Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants