-
Notifications
You must be signed in to change notification settings - Fork 272
refactor: improve code smell for postprocessing #1368
refactor: improve code smell for postprocessing #1368
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/9umBkf7ZqLkfuxtJcntRgm69YnJ6 |
Codecov Report
@@ Coverage Diff @@
## master #1368 +/- ##
==========================================
+ Coverage 30.18% 30.35% +0.17%
==========================================
Files 492 495 +3
Lines 9886 9896 +10
Branches 1666 1666
==========================================
+ Hits 2984 3004 +20
+ Misses 6655 6648 -7
+ Partials 247 244 -3
Continue to review full report at Codecov.
|
granularity: 'P1Y', | ||
}; | ||
|
||
describe('boxplotOperator', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you avoid nesting tests? You can just use test
on the top level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for improving the code organization.
🏆 Enhancements
No functional changes, some refactor for postprocessing. Added boxplotOperator, contributionOperator and prophetOperator.