This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
Feat: improve caching #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kristw @xtinec I'm getting unrelated build errors in this PR, any idea what might be going on? |
|
@betodealmeida I've made some change to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
This PR changes
SupersetClientso that it can reuse cached responses using the Cache API, in addition to delegating it to the browser. This allows us to passcache: 'no-cache', bypassing the browser caching and handling it ourselves.The reason for this is that using the native browser cache we're unable to invalidate the cache from Javascript, eg, when a user saves a new chart of force refreshes a dashboard. Using the Cache API we can easily do that, clearing all cached responses that reference a chart (see apache/superset#7319).