-
Notifications
You must be signed in to change notification settings - Fork 272
chore: upgrade storybook to 6.3.12 #1409
chore: upgrade storybook to 6.3.12 #1409
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/HS1wse27cFDsvwjQGX4DxTitdoZu |
Codecov Report
@@ Coverage Diff @@
## master #1409 +/- ##
=======================================
Coverage 30.41% 30.41%
=======================================
Files 497 497
Lines 9996 9996
Branches 1687 1687
=======================================
Hits 3040 3040
Misses 6710 6710
Partials 246 246
Continue to review full report at Codecov.
|
This looks awesome! Code changes look great, but when testing I noticed that the resizable charts don't seem to work correctly: AFTERsb-after.mp4BEFOREsb-before.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 🚀 Let's merge this one and figure out the resizing bug in a follow-up PR, as this can be considered a cosmetic bug but being stuck on Storybook 5 is a major blocker for monorepo.
🏠 Internal
@superset-ui/core
, avoid import from lib or esm directorya.
"@storybook/preset-typescript": "^3.0.0",
b.
"@types/storybook__react": "5.2.1
How to test