Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: upgrade storybook to 6.3.12 #1409

Merged
merged 3 commits into from
Oct 18, 2021

Conversation

zhaoyongjie
Copy link
Contributor

@zhaoyongjie zhaoyongjie commented Oct 15, 2021

🏠 Internal

  1. upgrade storybook and add-ons to 6.3.12
  2. export color schema @superset-ui/core, avoid import from lib or esm directory
  3. remove unused package from package.json
    a. "@storybook/preset-typescript": "^3.0.0",
    b. "@types/storybook__react": "5.2.1

How to test

  1. yarn
  2. yarn build
  3. yarn storybook

@zhaoyongjie zhaoyongjie requested a review from a team as a code owner October 15, 2021 15:01
@vercel
Copy link

vercel bot commented Oct 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/HS1wse27cFDsvwjQGX4DxTitdoZu
✅ Preview: https://superset-ui-git-fork-zhaoyongjie-bumpstorybook-superset.vercel.app

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #1409 (7457947) into master (bac1afb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1409   +/-   ##
=======================================
  Coverage   30.41%   30.41%           
=======================================
  Files         497      497           
  Lines        9996     9996           
  Branches     1687     1687           
=======================================
  Hits         3040     3040           
  Misses       6710     6710           
  Partials      246      246           
Impacted Files Coverage Δ
packages/superset-ui-core/src/color/index.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac1afb...7457947. Read the comment docs.

@villebro
Copy link
Contributor

This looks awesome! Code changes look great, but when testing I noticed that the resizable charts don't seem to work correctly:

AFTER

sb-after.mp4

BEFORE

sb-before.mp4

Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀 Let's merge this one and figure out the resizing bug in a follow-up PR, as this can be considered a cosmetic bug but being stuck on Storybook 5 is a major blocker for monorepo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants