Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

chore: add ref type for superchart #1411

Merged

Conversation

pkdotson
Copy link
Contributor

💔 Breaking Changes

🏆 Enhancements
Adds parentRef type to the superchart. Need for this pr: apache/superset#17046
📜 Documentation

🐛 Bug Fix

🏠 Internal

@pkdotson pkdotson requested a review from a team as a code owner October 18, 2021 21:21
@vercel
Copy link

vercel bot commented Oct 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/2P7giX17wEwME62YF4ReRRu5kTLf
✅ Preview: https://superset-ui-git-fork-preset-io-update-superchar-d507f2-superset.vercel.app

@pkdotson pkdotson changed the title add ref type for superchart chore: add ref type for superchart Oct 18, 2021
@pkdotson pkdotson requested review from rusackas and suddjian October 18, 2021 21:21
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #1411 (2ab0707) into master (794e540) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1411   +/-   ##
=======================================
  Coverage   30.41%   30.41%           
=======================================
  Files         497      497           
  Lines        9996     9996           
  Branches     1687     1687           
=======================================
  Hits         3040     3040           
  Misses       6710     6710           
  Partials      246      246           
Impacted Files Coverage Δ
...perset-ui-core/src/chart/components/SuperChart.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 794e540...2ab0707. Read the comment docs.

@pkdotson pkdotson merged commit f9be2bf into apache-superset:master Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants