Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: add storybook for missing chart and fix broken treemap #1427

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

stephenLYZ
Copy link
Contributor

🏆 Enhancements
support storybook 6 for missing chart:

  • radar
  • gauge
  • graph

@stephenLYZ stephenLYZ requested a review from a team as a code owner October 25, 2021 14:07
@vercel
Copy link

vercel bot commented Oct 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/HtjfMX5gQK6BEYHJfdBAkeq8RZrA
✅ Preview: https://superset-ui-git-fork-stephenlyz-fix-storybook-echarts-superset.vercel.app

Copy link
Contributor

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing these!

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #1427 (2080eb0) into master (23689b4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1427   +/-   ##
=======================================
  Coverage   30.43%   30.43%           
=======================================
  Files         497      497           
  Lines       10000    10000           
  Branches     1689     1689           
=======================================
  Hits         3043     3043           
  Misses       6711     6711           
  Partials      246      246           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23689b4...2080eb0. Read the comment docs.

@villebro villebro merged commit a10ee4b into apache-superset:master Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants