Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: adds the option to show values for mixed time-series #1435

Conversation

michael-s-molina
Copy link
Contributor

🏆 Enhancements

Adds the option to show values for the mixed time-series chart.

@junlincc @rusackas

Screen.Recording.2021-10-26.at.10.56.25.AM.mov

@vercel
Copy link

vercel bot commented Oct 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/Bnmod1JLKaL4pBMLLTmhr5F4PWvc
✅ Preview: https://superset-ui-git-fork-michael-s-molina-add-show-20527f-superset.vercel.app

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #1435 (60f1ae3) into master (a10ee4b) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1435   +/-   ##
=======================================
  Coverage   30.43%   30.43%           
=======================================
  Files         497      497           
  Lines       10000    10000           
  Branches     1689     1689           
=======================================
  Hits         3043     3043           
  Misses       6711     6711           
  Partials      246      246           
Impacted Files Coverage Δ
...chart-echarts/src/MixedTimeseries/controlPanel.tsx 80.00% <ø> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
.../plugin-chart-echarts/src/MixedTimeseries/types.ts 100.00% <ø> (ø)
...s/legacy-plugin-chart-country-map/src/countries.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a10ee4b...60f1ae3. Read the comment docs.

Copy link
Contributor

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit e17ceb6 into apache-superset:master Oct 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants