Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(plugin-chart-echarts): support show annotation label [ID-8] #1449

Merged

Conversation

stephenLYZ
Copy link
Contributor

@stephenLYZ stephenLYZ commented Nov 1, 2021

🏆 Enhancements
supports annotation showLabel field. related to apache/superset#17307

@stephenLYZ stephenLYZ requested a review from a team as a code owner November 1, 2021 16:00
@vercel
Copy link

vercel bot commented Nov 1, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/7W9znN4fAWDyuMhBiq7QidwMdcC1
✅ Preview: https://superset-ui-git-fork-stephenlyz-feat-annotation-label-superset.vercel.app

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #1449 (a0f337f) into master (744d732) will increase coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1449      +/-   ##
==========================================
+ Coverage   30.43%   30.49%   +0.06%     
==========================================
  Files         497      498       +1     
  Lines       10013    10027      +14     
  Branches     1692     1694       +2     
==========================================
+ Hits         3047     3058      +11     
- Misses       6720     6721       +1     
- Partials      246      248       +2     
Impacted Files Coverage Δ
...uperset-ui-core/src/query/types/AnnotationLayer.ts 100.00% <ø> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 42.24% <50.00%> (-1.13%) ⬇️
...ui-chart-controls/src/operators/boxplotOperator.ts 100.00% <0.00%> (ø)
...superset-ui-core/src/query/types/PostProcessing.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 744d732...a0f337f. Read the comment docs.

@stephenLYZ stephenLYZ changed the title feat(plugin-chart-echarts): support show annotation label feat(plugin-chart-echarts): support show annotation label [ID-8] Nov 1, 2021
Copy link
Contributor

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants