This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
Add tn / translateWithNumber #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 9 9
Lines 80 85 +5
=====================================
+ Hits 80 85 +5
Continue to review full report at Codecov.
|
williaster
reviewed
Oct 26, 2018
| expect(translator.translateWithNumber(undefined, undefined)).toBeUndefined(); | ||
| }); | ||
| it('returns original text for unknown text', () => { | ||
| expect(translator.translateWithNumber('fish', 'fishes', 1)).toEqual('fish'); |
There was a problem hiding this comment.
don't need another test, but curious how it behaves with 0 since that is the default num. is that singular?
There was a problem hiding this comment.
I think that depends on each languagePack. I saw there are DSL-ish field in the language packs that defines n for singular and plural.
"plural_forms": "nplurals=2; plural=(n != 1)",
kristw
added
reviewable
kristw
added a commit
that referenced
this pull request
Apr 17, 2020
* feat: add encodeable utilities * feat: add types back * refactor: simplify function calls * refactor: rename generic type * refactor: more edits * refactor: remove unused function * refactor: rename file * fix: address comments * fix: add vega back
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
tn(translateWithNumber) totranslationmodulesprintf-jsbecausejedalready comes withsprintf.