Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

[WIP] Improve SuperChart API #166

Closed
wants to merge 9 commits into from
Closed

[WIP] Improve SuperChart API #166

wants to merge 9 commits into from

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Jun 8, 2019

Split into #171, #172, #174 and #175.

@kristw kristw requested a review from a team as a code owner June 8, 2019 05:52
@netlify
Copy link

netlify bot commented Jun 8, 2019

Deploy preview for superset-ui ready!

Built with commit cc409d7

https://deploy-preview-166--superset-ui.netlify.com

@kristw kristw force-pushed the kristw--superchart branch from cf08d2a to adb8462 Compare June 10, 2019 23:50
@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #166 into master will decrease coverage by 3.29%.
The diff coverage is 67.25%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #166     +/-   ##
========================================
- Coverage     100%   96.7%   -3.3%     
========================================
  Files          88      92      +4     
  Lines        1095    1155     +60     
  Branches      263     283     +20     
========================================
+ Hits         1095    1117     +22     
- Misses          0      38     +38
Impacted Files Coverage Δ
...ckages/superset-ui-chart/src/models/ChartPlugin.ts 100% <ø> (ø) ⬆️
...registries/ChartTransformPropsRegistrySingleton.ts 100% <ø> (ø) ⬆️
...ackages/superset-ui-chart/src/models/ChartProps.ts 100% <100%> (ø) ⬆️
...rset-ui-chart/src/components/parseWidthOrHeight.ts 100% <100%> (ø)
...rset-ui-chart/src/components/FallbackComponent.tsx 100% <100%> (ø)
...erset-ui-chart/src/components/SuperChartKernel.tsx 100% <100%> (ø)
...es/superset-ui-chart/src/components/SuperChart.tsx 10% <5.4%> (-90%) ⬇️
...rset-ui-chart/test/components/MockChartPlugins.tsx 85.71% <85.71%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a405572...cc409d7. Read the comment docs.

@kristw kristw force-pushed the kristw--superchart branch from adb8462 to 53c51cb Compare June 11, 2019 01:09
@kristw kristw closed this Jun 13, 2019
@kristw kristw deleted the kristw--superchart branch June 18, 2019 04:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant