Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: store reference to container and update bindings #180

Merged
merged 3 commits into from
Jun 18, 2019

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Jun 18, 2019

🏆 Enhancements

  • feat: store reference to container

🏠 Internal

  • Remove constructor and bindings and declare functions that are bound as class variables.

@kristw kristw requested a review from a team as a code owner June 18, 2019 17:31
@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #180 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #180   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          94     94           
  Lines        1157   1159    +2     
  Branches      276    276           
=====================================
+ Hits         1157   1159    +2
Impacted Files Coverage Δ
...es/superset-ui-chart/src/components/SuperChart.tsx 100% <100%> (ø) ⬆️
...uperset-ui-chart/src/components/SuperChartCore.tsx 100% <100%> (ø) ⬆️
...perset-ui-chart/src/components/SuperChartShell.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a14c2b9...8b5f9bb. Read the comment docs.

@netlify
Copy link

netlify bot commented Jun 18, 2019

Deploy preview for superset-ui ready!

Built with commit 8b5f9bb

https://deploy-preview-180--superset-ui.netlify.com

Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 love not binding in constructors!

@kristw kristw added #code-quality #enhancement New feature or request reviewable Ready for review labels Jun 18, 2019
@kristw kristw merged commit 00e9a40 into master Jun 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--update-super-chart branch June 18, 2019 22:48
kristw pushed a commit that referenced this pull request Apr 17, 2020
…erflowing (#180)

* fix: horizon chart should scroll when overflowing

* fix: rebase and adapt

* fix: lint
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
#code-quality #enhancement New feature or request reviewable Ready for review size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants